Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for keymatch5 function #159

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

mikyll
Copy link
Contributor

@mikyll mikyll commented Nov 20, 2024

I added the support for keymatch5, based on Casbin (Go) implementation, with related tests 👀

Fixes #153

KeyMatch5 function ported from: casbin/casbin/util/builtin_operators.go
Tests ported from: casbin/casbin/util/builtin_operators_test.go

@mikyll
Copy link
Contributor Author

mikyll commented Nov 20, 2024

@hsluoyz the CI issue seems to be related to leafo/gh-actions-lua@v8.0.0 GitHub action...

Some insight: leafo/gh-actions-lua#49

From LuaJIT website:

No Release Tarballs or Binaries

LuaJIT uses rolling releases. There are no release tarballs available for download.

Please do not use obsolete versions from older tarballs or zip files. Please remove any outdated links to these downloads — these links will cease to work soon.

Do not use pseudo-releases or tarballs created by third parties. Do not use binaries offered for download by third parties.

Pre-built packages should only be installed via a trusted package manager for your operating system (distro). But you should be aware these often carry old versions that miss important fixes. Before reporting an issue, always try the latest version available from the git repository.

Distro maintainers for distros that require the fiction of a release should do frequent snapshots of a branch. Do not attempt to cherry-pick or backport individual changes, no matter how self-standing individual changes look (because they often are not).

@hsluoyz
Copy link
Member

hsluoyz commented Nov 21, 2024

@mikyll how to fix it? Is there any decision that requires me to make? Like there are solution A and solution B. The good and bad points of A are balabala, the good and bad points of B are balabala. Make your choice, something like this

@mikyll
Copy link
Contributor Author

mikyll commented Nov 22, 2024

@hsluoyz sorry for the delay, I opened a new issue and provided a possible solution. If that's ok I can open a new PR that fixes the CI issue (I've already tested the workflow on a fork and it appears to be working)

@hsluoyz hsluoyz closed this Nov 22, 2024
@hsluoyz hsluoyz reopened this Nov 22, 2024
@hsluoyz hsluoyz merged commit 399e18b into casbin:master Nov 22, 2024
14 of 16 checks passed
Copy link

🎉 This PR is included in version 1.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mikyll mikyll deleted the feat_keymatch5 branch November 22, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add keymatch5
2 participants