Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

function keyMatch3 does not match full string #214

Closed
abichinger opened this issue Nov 26, 2020 · 7 comments · Fixed by #215
Closed

function keyMatch3 does not match full string #214

abichinger opened this issue Nov 26, 2020 · 7 comments · Fixed by #215
Assignees
@hsluoyz
Labels
bug Something isn't working released

Comments

@abichinger
Copy link
Member

node-casbin/src/util/builtinOperators.ts

Line 91 in 5253b90

return regexMatch(key1, key2);

This line is missing ^ and $
@hsluoyz
Copy link
Member

hsluoyz commented Nov 26, 2020

@nodece

@hsluoyz hsluoyz self-assigned this Nov 26, 2020
@hsluoyz hsluoyz added the question Further information is requested label Nov 26, 2020
abichinger added a commit to abichinger/node-casbin that referenced this issue Nov 26, 2020
@abichinger
fix(builtinoperators): fix function keyMatch3
1245aa0 
fix casbin#214

Signed-off-by: Andreas Bichinger <andreas.bichinger@gmail.com>
@abichinger abichinger mentioned this issue Nov 26, 2020
Merged
@hsluoyz hsluoyz added bug Something isn't working and removed question Further information is requested labels Nov 27, 2020
@hsluoyz
Copy link
Member

hsluoyz commented Nov 27, 2020

@nodece @abichinger why is the Travis CI failing? https://travis-ci.org/github/casbin/node-casbin/jobs/746189398

image

@nodece
Copy link
Member

nodece commented Nov 27, 2020

@hsluoyz the job has been restart.

@hsluoyz
Copy link
Member

hsluoyz commented Nov 27, 2020

I have restarted once, but it failed again.

Is it because the title of this PR doesn't follow semantic-PR?

@abichinger
Copy link
Member Author 

/home/travis/build/casbin/node-casbin/node_modules/coveralls/bin/coveralls.js:19

      throw err;

      ^

Bad response: 422 {"message":"service_job_id (746189397) must be unique for Travis Jobs not supplying a Coveralls Repo Token","error":true}

(Use `node --trace-uncaught ...` to show where the exception was thrown)

The command "jest --coverage && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js && rm -rf ./coverage" exited with 1.

I think the failure of the latest build was caused by the restart. (see ckeditor/ckeditor5#7244)

The first build did not fail until the release stage.

@nodece
Copy link
Member

nodece commented Nov 29, 2020

@abichinger thanks, I migrated from Travis to GitHub Actions, and it works fine.

github-actions bot pushed a commit that referenced this issue Nov 29, 2020
@semantic-release-bot
chore(release): 5.2.2 [skip ci]
2c2f28b 
## [5.2.2](v5.2.1...v5.2.2) (2020-11-29)

### Bug Fixes

* **builtinoperators:** fix function keyMatch3 ([1245aa0](1245aa0)), closes [#214](#214)
@github-actions
Copy link

🎉 This issue has been resolved in version 5.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsluoyz hsluoyz

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(builtinoperators): fix function keyMatch3 abichinger/node-casbin
3 participants
@hsluoyz @abichinger @nodece