Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in ESM with Require function, v5.24.0 #434

Closed
IonVillarreal opened this issue Feb 23, 2023 · 6 comments · Fixed by #435
Closed

Problem in ESM with Require function, v5.24.0 #434

IonVillarreal opened this issue Feb 23, 2023 · 6 comments · Fixed by #435
Assignees
Labels
bug Something isn't working

Comments

@IonVillarreal
Copy link

hi I have a warning when using node-casbin with ESM in NextJS in the file ./node_modules/casbin/lib/esm/index.js

Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

Captura de pantalla 2023-02-23 a la(s) 11 02 11

The change was included in this pull request

#430

for now, i will use v5.23.2

@casbin-bot
Copy link
Member

@casbin-bot casbin-bot added the question Further information is requested label Feb 23, 2023
@nodece
Copy link
Member

nodece commented Feb 23, 2023

Does v5.24.0 not work?

@IonVillarreal
Copy link
Author

yes, in v5.24.0 I have the same warning

in version v5.23.2 that message does not appear

@hsluoyz
Copy link
Member

hsluoyz commented Feb 24, 2023

@nodece given this issue is caused by: #430 , can you fix it?

@nodece
Copy link
Member

nodece commented Feb 24, 2023

Hi @IonVillarreal, could you check the #435?

@IonVillarreal
Copy link
Author

Hi @nodece I just tried it, it works, the warning no longer appears 🙌

@hsluoyz hsluoyz added bug Something isn't working and removed question Further information is requested labels Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants