Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using import() to load the fs #435

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Conversation

nodece
Copy link
Member

@nodece nodece commented Feb 24, 2023

The require is unavailable in the ESM, so using the import instead.

Fix: #434

@casbin-bot
Copy link
Member

@Zxilly @Shivansh-yadav13 please review

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Copy link
Contributor

@Zxilly Zxilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsluoyz hsluoyz merged commit e90a8bf into casbin:master Feb 24, 2023
github-actions bot pushed a commit that referenced this pull request Feb 24, 2023
## [5.24.2](v5.24.1...v5.24.2) (2023-02-24)

### Bug Fixes

* using import() to load the fs ([#435](#435)) ([e90a8bf](e90a8bf))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem in ESM with Require function, v5.24.0
4 participants