fix(replaceeval): add third param to replaceEval and only replace eval() w/ matching ruleName #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l() w/ matching ruleName This fixes casbin#315. fix casbin#315
JoshuaCWebDeveloper
force-pushed
the
support-multiple-eval
branch
from
ad3dbb9 to
7298749
Compare
|
I tried following the instructions in the DCO details with the same result, not sure what the issue is. |
|
@Zxilly @Gabriel-403 plz reivew |
Zxilly
approved these changes
Aug 17, 2021
|
🎉 This PR is included in version 5.11.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
😬 Let me know if you want help with that. (And thanks!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #315.
I chose to go with a slightly more straightforward approach than what was done in casbin/casbin#620; however, this meant modifying an existing util function instead of creating a new one.