-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getContainerRenderWindow
in Saturation component inside iframe is causing a crash
#806
Comments
yarindeohcld
changed the title
Feb 21, 2021
getContainerRenderWindow
in Saturation component inside iframegetContainerRenderWindow
in Saturation component inside iframe is causing a crash
same problem, still finding solution |
Request to revert this PR #690 |
This was referenced Jun 30, 2021
tconkling
added a commit
to streamlit/streamlit
that referenced
this issue
Jul 6, 2021
On Streamlit Sharing, ColorPicker throws a cross-origin error when its popover window is closed. There's an issue open in the react-color repo (casesandberg/react-color#806) - but it's months old and hasn't had a developer response. With this PR, we now swallow all SecurityErrors thrown within `<ColorPicker>`. ColorPicker's functionality remains intact. Here's a sample app running on Sharing with this frontend fix: https://share.streamlit.io/tconkling/st_colorpicker_test/main/app.py Fixes #2689
still 2.19.3 |
Having this issue too and my panel is not even display the Saturation option! |
Fix is here: uiwjs/react-color#81 (comment) |
Execute: yarn add react-color@2.18.1 to install a specific version, without upgrading to 2.19.x." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm rendering a custom picker inside an iframe that is using
Saturation
common component.I'm receiving a CORS origin error that caused by the following code:
getContainerRenderWindow
after evaluating
renderWindow = renderWindow.parent
, there's no document to access and it caused the failures. What is the propose behind that ?a local fix was to override this method and return always
window
.any insights ? it need to be used in prod
The text was updated successfully, but these errors were encountered: