Allow react@v15 in peerDep #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump @casesandberg any chance you could merge this and push a patch to npm? Using this with react v15 works perfectly but throws errors with npm@2 because of the peer dependencies, and it's having all sort of knock-on effects with Travis... Thanks! |
|
Bump to merge this, this is the only package stopping us from upgrading to v15 |
|
Sorry for the delay y'all. You can find this on npm at |
|
Cheers @casesandberg, much appreciated |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-addons-shallow-compare has been moved to peer dependency because react-addons-shallow-compare v0.14 will have peer dependency on react 0.14. Any project that is using react v15 will see peer dependency error if react-addons-shallow-compare is present under dependencies.