Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prop being changed directly #362

Merged
merged 2 commits into from
Jun 27, 2017
Merged

Fix prop being changed directly #362

merged 2 commits into from
Jun 27, 2017

Conversation

ldanet
Copy link
Collaborator

@ldanet ldanet commented Jun 19, 2017

Fixes #360

@casesandberg
Copy link
Owner

While that dep is currently saved in the repo, will eventually be phasing it out. Can you write a test so that we make sure it will not break in the future?

@ldanet ldanet mentioned this pull request Jun 22, 2017
Merged
@ldanet
Copy link
Collaborator Author

ldanet commented Jun 22, 2017

I added tests for HSV and HSL colors which were the ones getting mutated.

@casesandberg casesandberg merged commit 7a8a6ee into casesandberg:master Jun 27, 2017
@casesandberg
Copy link
Owner

Thanks for all the help 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldanet @casesandberg