ONT-469 #67
Merged
ONT-469 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References: * [ONT-469] CASE needs a representation for a cellular tower Acked-by: Fabrizio Turchi <fabrizio.turchi@ittig.cnr.it> Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
AJN: This is a transcription of what Fabrizio emailed me and gave me permission to post. Syntax fixes to come in a follow-on patch.
This patch applies `python3 -m json.tool` as in other places in this repository.
The extra error seems to have been from the unrecognized prefix obscuring definition data, due to becoming annotations of string-literals.
References: * [ONT-469] CASE needs a representation for a cellular tower Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
There is a default-behavior difference between JSON-LD. The number-string `2.58` with no datatype annotation translates to: * `xsd:decimal` in Turtle [1] * `xsd:double` in JSON-LD [2] Since UCO transitioned to using `xsd:decimal` with Change Proposal 80, we will need to override JSON-LD's default behavior and annotate decimal numbers as `xsd:decimal`. References: 1. https://www.w3.org/TR/turtle/#abbrev 2. https://www.w3.org/TR/json-ld11/#conversion-of-native-data-types 3. [UCO OC-141] (CP-80) Normalize all decimal number properties within UCO to utilize xsd:decimal 4. [ONT-469] (UCO CP-101) CASE needs a representation for a cellular tower Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * [ONT-469] (UCO CP-101) CASE needs a representation for a cellular tower Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This did not affect validation results. References: * [ONT-469] (UCO CP-101) CASE needs a representation for a cellular tower Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This applies UCO vocabulary practices as of UCO 0.7.0. References: * [ONT-469] (UCO CP-101) CASE needs a representation for a cellular tower Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * [ONT-469] (UCO CP-101) CASE needs a representation for a cellular tower Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Synchronized with JSON updates based on discussion of change proposal.
Update property labels and definitions based on discussion of change proposal.
Removed "degrees" from property names because they are specified in the definition.
Removed "degrees" from the property names of antenna facet.
References: * [ONT-469] (UCO CP-101) CASE needs a representation for a cellular tower Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * [ONT-469] (UCO CP-101) CASE needs a representation for a cellular tower Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist
requested changes
May 27, 2022
examples/illustrations/cell_tower/src/query-connected_sites.sparql
Outdated
Show resolved
Hide resolved
| "@type": "drafting:AntennaFacet", | ||
| "drafting:azimuth": { | ||
| "@type": "xsd:decimal", | ||
| "@value": "45" |
There was a problem hiding this comment.
45 degrees from what? Is this True North based Azimuth ( https://en.wikipedia.org/wiki/Azimuth#True_north-based_azimuths )? If the Wikipedia definition specifies what this property means, we have been OK citing Wikipedia for other properties. Please review the observable namespace's Turtle file for wikipedia.org citation practices.
Comment on lines
+32
to
+35
| "drafting:signalStrength": { | ||
| "@type": "xsd:decimal", | ||
| "@value": "20" | ||
| }, |
There was a problem hiding this comment.
This looks significantly close to a measurement value that should incorporate time. What is the unit and/or scale of this property? Count of bars on a phone display? Or, is this truly a fixed property of the antenna?
| "drafting:cellSiteIdentifier": "29220952" | ||
| }, | ||
| { | ||
| "@type": "drafting:AntennaFacet", |
There was a problem hiding this comment.
Are we deliberately not defining a drafting:Antenna class, subclass of observable:Device?
There was a problem hiding this comment.
Also, should drafting:AntennaFacet be renamed to drafting:CellSiteAntenna? Is there a more general Antenna class we would want to represent?
A follow-on patch will regenerate Make-managed files. References: * [ONT-469] (UCO CP-101) CASE needs a representation for a cellular tower Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * [ONT-469] (UCO CP-101) CASE needs a representation for a cellular tower Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
7 tasks
Changed UnallocatedRecoverability to RecoveredObject
Changed UnallocatedRecoverability to RecoveredObject
Updated UnallocatedRecoverability to RecoveredObject
Revert changes
Revert changes
Revert changes
|
The committee voted to let this state be the implementation. Merging now, so the 1.0.0 release state of this illustration can be prepared. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.