Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change minCount from 1 to 0 on multiple properties on Investigation object #98

Closed
7 tasks done
eoghanscasey opened this issue Aug 3, 2022 · 4 comments · Fixed by #104
Closed
7 tasks done

Change minCount from 1 to 0 on multiple properties on Investigation object #98

eoghanscasey opened this issue Aug 3, 2022 · 4 comments · Fixed by #104
Assignees
Milestone

Comments

@eoghanscasey
Copy link

eoghanscasey commented Aug 3, 2022

This is proposed as a FastTrack change

Background

Most properties in CASE are optional. Setting minCount = 1 is enforced by SHACL makes a property required. This constraint will create problems in use cases in which a property is known to have existed but the value is not available.

Requirements

Requirement 1

Allow adopters to create an object when the existence of an object is known but an associated property is not known.

Risk / Benefit analysis

The proposed change allows adopters to decide which property is needed, except when it is ontologically necessary.

Benefits

Allow adopters to decide which property is needed.

Risks

The submitter is unaware of risks associated with this change.

Competencies demonstrated

Adopter creates an object when the existence of an object is known but an associated property is not known.

Solution suggestion

Change minCount to 0 from 1 on the following Investigation properties:

  • authorizationType
  • authorizationIdentifier
  • authorizationForm

Coordination

  • Tracking in Jira ticket ONT-482
  • Administrative review completed
  • Solutions Approval to be discussed in OC meeting, date 2022-08-16
  • Solutions Approval vote occurred, not passing, on 2022-08-16
  • Solutions development phase completed.
  • Implementation merged into develop
  • Milestone linked
  • Documentation logged in pending release page
@ajnelson-nist ajnelson-nist added this to the CASE 1.0.0 milestone Aug 15, 2022
@plbt5
Copy link
Contributor

plbt5 commented Aug 20, 2022

@eoghanscasey Is it possible that you intended to change investigationForm as opposed to authorizationForm? I cannot find the latter, while the former is present in investigation.ttl. Please clarify; I've already changed the other two.

@eoghanscasey
Copy link
Author

@plbt5 Yes, I did mean investigationForm. Thank you for this correction.

@plbt5
Copy link
Contributor

plbt5 commented Aug 22, 2022

@ajnelson-nist : Running make check throwed an error. Following your comment on rtf-toolkit here, I was able to correct my local UCO clone as well. Thanks for providing that solution.

However, running the (now corrected) make check results in 2 passed, 1 xfailed. Does that imply:

  1. that one verification failed, or
  2. that one falsification succeeded, i.e., success for all three?

@ajnelson-nist
Copy link
Member

@plbt5 : I suppose the extra comment on rdf-toolkit is worth a more careful make clean rule to catch this issue.

xfail is considered a success - it is a test eXpected to Fail in a specific way, via targeted inducement.

@plbt5 plbt5 mentioned this issue Aug 22, 2022
10 tasks
@plbt5 plbt5 assigned ajnelson-nist and eoghanscasey and unassigned plbt5 Aug 22, 2022
@ajnelson-nist ajnelson-nist linked a pull request Aug 23, 2022 that will close this issue
10 tasks
ajnelson-nist added a commit to casework/CASE-Examples that referenced this issue Aug 23, 2022
A follow-on patch will regenerate Make-managed files.

References:
* casework/CASE#98

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Examples that referenced this issue Aug 23, 2022
References:
* casework/CASE#98

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue Aug 23, 2022
A follow-on patch will regenerate Make-managed files.

References:
* casework/CASE#98

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue Aug 23, 2022
References:
* casework/CASE#98

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants