Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm an InvestigativeAction results in at least one ProvenanceRecord #147

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Confirm an InvestigativeAction results in at least one ProvenanceRecord #147

wants to merge 3 commits into from

Conversation

ajnelson-nist
Copy link
Member

@ajnelson-nist ajnelson-nist commented Jan 23, 2024 •
edited
Loading

This Pull Request resolves all backwards-compatible requirements of Issue #146 .

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in CASE feature branch against develop
  • CI passes in CASE current unstable branch (merge-commit)
  • Impact on SHACL validation reviewed for CASE-Corpora
  • Impact on SHACL validation remediated for CASE-Corpora
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

@ajnelson-nist
Confirm an InvestigativeAction results in at least one ProvenanceRecord
a4802b5 
This new shape stemmed from discussion on CASE Issue 136.

As a matter of preserving backwards compatibility, this patch introduces
the shape requiring `ProvenanceRecord`s with a `sh:Warning`-level
severity.  In CASE 2.0.0, this requirement will be strengthened into a
`sh:Violation`.

A separate proposal will be filed with UCO to test the minimum qualified
cardinality OWL structure.  A draft of that syntax review system was
used to test this patch.

This patch adds a version floor for pySHACL to ensure an update in
qualified value shape handling is included, which is necessary for the
new property shape to function when using pySHACL.

Disclaimer:

References:
* RDFLib/pySHACL#213
* #136
* #146

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist added this to the CASE 1.x.0 milestone Jan 23, 2024
@ajnelson-nist ajnelson-nist linked an issue Jan 23, 2024 that may be closed by this pull request
InvestigativeActions should be required to produce at least one ProvenanceRecord #146
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
CASE 1.x.0
Development

Successfully merging this pull request may close these issues.

InvestigativeActions should be required to produce at least one ProvenanceRecord
1 participant
@ajnelson-nist