Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add working-directory docs #2288

Merged
merged 5 commits into from
Aug 2, 2024
Merged

add working-directory docs #2288

merged 5 commits into from
Aug 2, 2024

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Aug 1, 2024

No description provided.

@nyurik nyurik marked this pull request as ready for review August 1, 2024 18:19
@casey
Copy link
Owner

casey commented Aug 1, 2024

Good call on adding some docs. Can you change it so that the existing example isn't changed, and add a new example with set working-directory?

casey
casey requested changes Aug 1, 2024
View reviewed changes
Copy link
Owner

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

casey
casey approved these changes Aug 2, 2024
View reviewed changes
Copy link
Owner

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@casey casey enabled auto-merge (squash) August 2, 2024 19:49
@casey casey merged commit cf4c726 into casey:master Aug 2, 2024
5 checks passed
@nyurik nyurik deleted the patch-1 branch August 2, 2024 21:33
@BrewTestBot BrewTestBot mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casey casey casey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyurik @casey