Remember hydrometer calibration temp. Fixes #55. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseydavenport
requested changes
Sep 18, 2016
| } | ||
| else { | ||
| calibTempEditText.setText("20"); | ||
| String calibTemp=preferences.getString(Constants.PREF_HYDROMETER_CALIBRATION_TEMP,"68"); |
There was a problem hiding this comment.
I think this one should be "20" instead of "68" since it's in Celsius.
| @@ -235,7 +235,9 @@ public void onDrawerOpened(View drawerView) { | |||
| fragmentList.add(new EditMashProfilesFragment()); | |||
| fragmentList.add(new ViewStylesFragment()); | |||
| fragmentList.add(new StrikeWaterCalculatorFragment()); | |||
| fragmentList.add(new HydrometerTempCalculatorFragment()); | |||
| HydrometerTempCalculatorFragment hydrometerTempCalculatorFragment = new HydrometerTempCalculatorFragment(); | |||
There was a problem hiding this comment.
I think that instead of passing in the preferences here, you could do something like this inside of the fragment itself whenever you need to access the preferences:
this.getActivity().getSharedPreferences(Constants.PREFERENCES, Context.MODE_PRIVATE)
My concern being that, if the fragment is destroyed / re-created by Android at some point, the way it is now it might lose the passed in preferences object and hydrometerTempCalculatorFragment.preferences could end up a null pointer.
|
I have updated the files as requested - you were right on both counts. |
caseydavenport
approved these changes
Sep 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Giving the Hydrometer calculator fragment access to global prefs could probably be done more elegantly, but this is simple and works.