Add snapshot tests for iOS 17

cashapp · Jan 25, 2024 · 0d90140 · 0d90140
1 parent 3a6b9eb
commit 0d90140
Show file tree

Hide file tree

Showing 99 changed files with 7 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -12,7 +12,7 @@ jobs:
     runs-on: macOS-13
     strategy:
       matrix:
-        platform: ['iOS_16']
+        platform: ['iOS_17', 'iOS_16']
       fail-fast: false
     steps:
       - name: Checkout Repo

diff --git a/Example/SnapshotTests/ImpreciseObjectiveCTests.m b/Example/SnapshotTests/ImpreciseObjectiveCTests.m
@@ -31,6 +31,7 @@ - (void)setUp;
     [super setUp];
 
     self.fileNameOptions = FBSnapshotTestCaseFileNameIncludeOptionOS | FBSnapshotTestCaseFileNameIncludeOptionScreenSize | FBSnapshotTestCaseFileNameIncludeOptionScreenScale;
+    self.recordMode = NO;
 }
 
 - (void)testSimpleView;

diff --git a/Example/SnapshotTests/ObjectiveCTests.m b/Example/SnapshotTests/ObjectiveCTests.m
@@ -31,6 +31,7 @@ - (void)setUp;
     [super setUp];
 
     self.fileNameOptions = FBSnapshotTestCaseFileNameIncludeOptionOS | FBSnapshotTestCaseFileNameIncludeOptionScreenSize | FBSnapshotTestCaseFileNameIncludeOptionScreenScale;
+    self.recordMode = NO;
 }
 
 - (void)testSimpleView;

diff --git a/...ciseObjectiveCTests/testSimpleViewWithActivationPointAlways_17_2_393x852@3x.png b/...ciseObjectiveCTests/testSimpleViewWithActivationPointAlways_17_2_393x852@3x.png
diff --git a/...ciseObjectiveCTests/testSimpleViewWithIdentifier_identifier_17_2_393x852@3x.png b/...ciseObjectiveCTests/testSimpleViewWithIdentifier_identifier_17_2_393x852@3x.png
diff --git a/...ReferenceImages/_64/ImpreciseObjectiveCTests/testSimpleView_17_2_393x852@3x.png b/...ReferenceImages/_64/ImpreciseObjectiveCTests/testSimpleView_17_2_393x852@3x.png
diff --git a/...ges/_64/ImpreciseObjectiveCTests/testViewWithInvertedColors_17_2_393x852@3x.png b/...ges/_64/ImpreciseObjectiveCTests/testViewWithInvertedColors_17_2_393x852@3x.png
diff --git a/...hotTests/ReferenceImages/_64/ObjectiveCTests/testHitTargets_17_2_393x852@3x.png b/...hotTests/ReferenceImages/_64/ObjectiveCTests/testHitTargets_17_2_393x852@3x.png
diff --git a/..._64/ObjectiveCTests/testSimpleViewWithActivationPointAlways_17_2_393x852@3x.png b/..._64/ObjectiveCTests/testSimpleViewWithActivationPointAlways_17_2_393x852@3x.png
diff --git a/...64/ObjectiveCTests/testSimpleViewWithActivationPointDefault_17_2_393x852@3x.png b/...64/ObjectiveCTests/testSimpleViewWithActivationPointDefault_17_2_393x852@3x.png
diff --git a/.../_64/ObjectiveCTests/testSimpleViewWithActivationPointNever_17_2_393x852@3x.png b/.../_64/ObjectiveCTests/testSimpleViewWithActivationPointNever_17_2_393x852@3x.png
diff --git a/...Images/_64/ObjectiveCTests/testSimpleViewWithColorSnapshots_17_2_393x852@3x.png b/...Images/_64/ObjectiveCTests/testSimpleViewWithColorSnapshots_17_2_393x852@3x.png
diff --git a/..._64/ObjectiveCTests/testSimpleViewWithIdentifier_identifier_17_2_393x852@3x.png b/..._64/ObjectiveCTests/testSimpleViewWithIdentifier_identifier_17_2_393x852@3x.png
diff --git a/...hotTests/ReferenceImages/_64/ObjectiveCTests/testSimpleView_17_2_393x852@3x.png b/...hotTests/ReferenceImages/_64/ObjectiveCTests/testSimpleView_17_2_393x852@3x.png
diff --git a/...erenceImages/_64/ObjectiveCTests/testViewWithInvertedColors_17_2_393x852@3x.png b/...erenceImages/_64/ObjectiveCTests/testViewWithInvertedColors_17_2_393x852@3x.png
diff --git a/...Tests.AccessibilityContainersTests/testDataTableWithHeaders_17_2_393x852@3x.png b/...Tests.AccessibilityContainersTests/testDataTableWithHeaders_17_2_393x852@3x.png
diff --git a/...AccessibilityContainersTests/testDataTableWithUndefinedRows_17_2_393x852@3x.png b/...AccessibilityContainersTests/testDataTableWithUndefinedRows_17_2_393x852@3x.png
diff --git a/...64/SnapshotTests.AccessibilityContainersTests/testDataTable_17_2_393x852@3x.png b/...64/SnapshotTests.AccessibilityContainersTests/testDataTable_17_2_393x852@3x.png
diff --git a/..._64/SnapshotTests.AccessibilityContainersTests/testLandmark_17_2_393x852@3x.png b/..._64/SnapshotTests.AccessibilityContainersTests/testLandmark_17_2_393x852@3x.png
diff --git a/...ges/_64/SnapshotTests.AccessibilityContainersTests/testList_17_2_393x852@3x.png b/...ges/_64/SnapshotTests.AccessibilityContainersTests/testList_17_2_393x852@3x.png
diff --git a/...shotTests.AccessibilitySnapshotTests/testAccessibilityPaths_17_2_393x852@3x.png b/...shotTests.AccessibilitySnapshotTests/testAccessibilityPaths_17_2_393x852@3x.png
diff --git a/...4/SnapshotTests.AccessibilitySnapshotTests/testButtonTraits_17_2_393x852@3x.png b/...4/SnapshotTests.AccessibilitySnapshotTests/testButtonTraits_17_2_393x852@3x.png
diff --git a/.../SnapshotTests.AccessibilitySnapshotTests/testCustomActions_17_2_393x852@3x.png b/.../SnapshotTests.AccessibilitySnapshotTests/testCustomActions_17_2_393x852@3x.png
diff --git a/...otTests.AccessibilitySnapshotTests/testDescriptionEdgeCases_17_2_393x852@3x.png b/...otTests.AccessibilitySnapshotTests/testDescriptionEdgeCases_17_2_393x852@3x.png
diff --git a/...apshotTests.AccessibilitySnapshotTests/testLabelDescription_17_2_393x852@3x.png b/...apshotTests.AccessibilitySnapshotTests/testLabelDescription_17_2_393x852@3x.png
diff --git a/...bilitySnapshotTests/testLargeViewAndReturnError__monochrome_17_2_393x852@3x.png b/...bilitySnapshotTests/testLargeViewAndReturnError__monochrome_17_2_393x852@3x.png
diff --git a/...bilitySnapshotTests/testLargeViewAndReturnError__polychrome_17_2_393x852@3x.png b/...bilitySnapshotTests/testLargeViewAndReturnError__polychrome_17_2_393x852@3x.png
diff --git a/...SnapshotTests.AccessibilitySnapshotTests/testSwitchControls_17_2_393x852@3x.png b/...SnapshotTests.AccessibilitySnapshotTests/testSwitchControls_17_2_393x852@3x.png
diff --git a/...es/_64/SnapshotTests.AccessibilitySnapshotTests/testTabBars_17_2_393x852@3x.png b/...es/_64/SnapshotTests.AccessibilitySnapshotTests/testTabBars_17_2_393x852@3x.png
diff --git a/...pshotTests/testViewAsSubviewOfViewInViewControllerHierarchy_17_2_393x852@3x.png b/...pshotTests/testViewAsSubviewOfViewInViewControllerHierarchy_17_2_393x852@3x.png
diff --git a/...napshotTests.AccessibilitySnapshotTests/testViewDescription_17_2_393x852@3x.png b/...napshotTests.AccessibilitySnapshotTests/testViewDescription_17_2_393x852@3x.png
diff --git a/...ccessibilitySnapshotTests/testViewInViewControllerHierarchy_17_2_393x852@3x.png b/...ccessibilitySnapshotTests/testViewInViewControllerHierarchy_17_2_393x852@3x.png
diff --git a/...pshotTests.ActivationPointTests/testActivationPointDisabled_17_2_393x852@3x.png b/...pshotTests.ActivationPointTests/testActivationPointDisabled_17_2_393x852@3x.png
diff --git a/...tivationPointTests/testActivationPointEnabledWhenOverridden_17_2_393x852@3x.png b/...tivationPointTests/testActivationPointEnabledWhenOverridden_17_2_393x852@3x.png
diff --git a/...apshotTests.ActivationPointTests/testActivationPointEnabled_17_2_393x852@3x.png b/...apshotTests.ActivationPointTests/testActivationPointEnabled_17_2_393x852@3x.png
diff --git a/...ages/_64/SnapshotTests.DefaultControlsTests/testPageControl_17_2_393x852@3x.png b/...ages/_64/SnapshotTests.DefaultControlsTests/testPageControl_17_2_393x852@3x.png
diff --git a/..._64/SnapshotTests.DefaultControlsTests/testSegmentedControl_17_2_393x852@3x.png b/..._64/SnapshotTests.DefaultControlsTests/testSegmentedControl_17_2_393x852@3x.png
diff --git a/...nceImages/_64/SnapshotTests.DefaultControlsTests/testSlider_17_2_393x852@3x.png b/...nceImages/_64/SnapshotTests.DefaultControlsTests/testSlider_17_2_393x852@3x.png
diff --git a/...ges/_64/SnapshotTests.DefaultControlsTests/testStepperAtMin_17_2_393x852@3x.png b/...ges/_64/SnapshotTests.DefaultControlsTests/testStepperAtMin_17_2_393x852@3x.png
diff --git a/...ceImages/_64/SnapshotTests.DefaultControlsTests/testStepper_17_2_393x852@3x.png b/...ceImages/_64/SnapshotTests.DefaultControlsTests/testStepper_17_2_393x852@3x.png
diff --git a/...SnapshotTests.ElementOrderTests/testContainerInElementStack_17_2_393x852@3x.png b/...SnapshotTests.ElementOrderTests/testContainerInElementStack_17_2_393x852@3x.png
diff --git a/...eferenceImages/_64/SnapshotTests.ElementOrderTests/testGrid_17_2_393x852@3x.png b/...eferenceImages/_64/SnapshotTests.ElementOrderTests/testGrid_17_2_393x852@3x.png
diff --git a/...pshotTests.ElementOrderTests/testGroupedViewsInElementStack_17_2_393x852@3x.png b/...pshotTests.ElementOrderTests/testGroupedViewsInElementStack_17_2_393x852@3x.png
diff --git a/...renceImages/_64/SnapshotTests.ElementOrderTests/testScatter_17_2_393x852@3x.png b/...renceImages/_64/SnapshotTests.ElementOrderTests/testScatter_17_2_393x852@3x.png
diff --git a/...ests.ElementOrderTests/testUngroupedViewsInAccessibleParent_17_2_393x852@3x.png b/...ests.ElementOrderTests/testUngroupedViewsInAccessibleParent_17_2_393x852@3x.png
diff --git a/...hotTests.ElementOrderTests/testUngroupedViewsInElementStack_17_2_393x852@3x.png b/...hotTests.ElementOrderTests/testUngroupedViewsInElementStack_17_2_393x852@3x.png
diff --git a/...ests.ElementOrderTests/testZeroSizedContainerInElementStack_17_2_393x852@3x.png b/...ests.ElementOrderTests/testZeroSizedContainerInElementStack_17_2_393x852@3x.png
diff --git a/...ests.ElementSelectionTests/testAccessibilityContainerHidden_17_2_393x852@3x.png b/...ests.ElementSelectionTests/testAccessibilityContainerHidden_17_2_393x852@3x.png
diff --git a/...SelectionTests/testAccessibilityContainerWithElementsHidden_17_2_393x852@3x.png b/...SelectionTests/testAccessibilityContainerWithElementsHidden_17_2_393x852@3x.png
diff --git a/...pshotTests.ElementSelectionTests/testAccessibilityContainer_17_2_393x852@3x.png b/...pshotTests.ElementSelectionTests/testAccessibilityContainer_17_2_393x852@3x.png
diff --git a/...tTests.ElementSelectionTests/testAccessibilityElementHidden_17_2_393x852@3x.png b/...tTests.ElementSelectionTests/testAccessibilityElementHidden_17_2_393x852@3x.png
diff --git a/...ntSelectionTests/testAccessibilityElementWithElementsHidden_17_2_393x852@3x.png b/...ntSelectionTests/testAccessibilityElementWithElementsHidden_17_2_393x852@3x.png
diff --git a/...tTests.ElementSelectionTests/testGroupedViewsInHiddenParent_17_2_393x852@3x.png b/...tTests.ElementSelectionTests/testGroupedViewsInHiddenParent_17_2_393x852@3x.png
diff --git a/...entSelectionTests/testGroupedViewsInParentThatHidesElements_17_2_393x852@3x.png b/...entSelectionTests/testGroupedViewsInParentThatHidesElements_17_2_393x852@3x.png
diff --git a/...es/_64/SnapshotTests.ElementSelectionTests/testGroupedViews_17_2_393x852@3x.png b/...es/_64/SnapshotTests.ElementSelectionTests/testGroupedViews_17_2_393x852@3x.png
diff --git a/...tTests.ElementSelectionTests/testMixedAccessibilityElements_17_2_393x852@3x.png b/...tTests.ElementSelectionTests/testMixedAccessibilityElements_17_2_393x852@3x.png
diff --git a/...shotTests.ElementSelectionTests/testNoAccessibilityElements_17_2_393x852@3x.png b/...shotTests.ElementSelectionTests/testNoAccessibilityElements_17_2_393x852@3x.png
diff --git a/...hotTests.ElementSelectionTests/testTwoAccessibilityElements_17_2_393x852@3x.png b/...hotTests.ElementSelectionTests/testTwoAccessibilityElements_17_2_393x852@3x.png
diff --git a/...Images/_64/SnapshotTests.HighlightTests/testColorInSnapshot_17_2_393x852@3x.png b/...Images/_64/SnapshotTests.HighlightTests/testColorInSnapshot_17_2_393x852@3x.png
diff --git a/...ReferenceImages/_64/SnapshotTests.HighlightTests/testColors_17_2_393x852@3x.png b/...ReferenceImages/_64/SnapshotTests.HighlightTests/testColors_17_2_393x852@3x.png
diff --git a/...eferenceImages/_64/SnapshotTests.HighlightTests/testOverlap_17_2_393x852@3x.png b/...eferenceImages/_64/SnapshotTests.HighlightTests/testOverlap_17_2_393x852@3x.png
diff --git a/...Images/_64/SnapshotTests.HitTargetTests/testButtonHitTarget_17_2_393x852@3x.png b/...Images/_64/SnapshotTests.HitTargetTests/testButtonHitTarget_17_2_393x852@3x.png
diff --git a/...pshotTests.HitTargetTests/testTableHitTargetAndReturnError__17_2_393x852@3x.png b/...pshotTests.HitTargetTests/testTableHitTargetAndReturnError__17_2_393x852@3x.png
diff --git a/...rtColorsTests/testInvertColorsWithIdentifier_someIdentifier_17_2_393x852@3x.png b/...rtColorsTests/testInvertColorsWithIdentifier_someIdentifier_17_2_393x852@3x.png
diff --git a/...Images/_64/SnapshotTests.InvertColorsTests/testInvertColors_17_2_393x852@3x.png b/...Images/_64/SnapshotTests.InvertColorsTests/testInvertColors_17_2_393x852@3x.png
diff --git a/...4/SnapshotTests.InvertColorsTests/testInvertColors_disabled_17_2_393x852@3x.png b/...4/SnapshotTests.InvertColorsTests/testInvertColors_disabled_17_2_393x852@3x.png
diff --git a/.../ReferenceImages/_64/SnapshotTests.LayoutTests/testClipping_17_2_393x852@3x.png b/.../ReferenceImages/_64/SnapshotTests.LayoutTests/testClipping_17_2_393x852@3x.png
diff --git a/.../_64/SnapshotTests.LayoutTests/testFullScreenWithFewMarkers_17_2_393x852@3x.png b/.../_64/SnapshotTests.LayoutTests/testFullScreenWithFewMarkers_17_2_393x852@3x.png
diff --git a/...SnapshotTests.LayoutTests/testFullScreenWithManyManyMarkers_17_2_393x852@3x.png b/...SnapshotTests.LayoutTests/testFullScreenWithManyManyMarkers_17_2_393x852@3x.png
diff --git a/..._64/SnapshotTests.LayoutTests/testFullScreenWithManyMarkers_17_2_393x852@3x.png b/..._64/SnapshotTests.LayoutTests/testFullScreenWithManyMarkers_17_2_393x852@3x.png
diff --git a/...ges/_64/SnapshotTests.LayoutTests/testLongMarkerDescription_17_2_393x852@3x.png b/...ges/_64/SnapshotTests.LayoutTests/testLongMarkerDescription_17_2_393x852@3x.png
diff --git a/.../ReferenceImages/_64/SnapshotTests.LayoutTests/testStandard_17_2_393x852@3x.png b/.../ReferenceImages/_64/SnapshotTests.LayoutTests/testStandard_17_2_393x852@3x.png
diff --git a/...es/_64/SnapshotTests.LayoutTests/testWideViewWithFewMarkers_17_2_393x852@3x.png b/...es/_64/SnapshotTests.LayoutTests/testWideViewWithFewMarkers_17_2_393x852@3x.png
diff --git a/...s/_64/SnapshotTests.LayoutTests/testWideViewWithManyMarkers_17_2_393x852@3x.png b/...s/_64/SnapshotTests.LayoutTests/testWideViewWithManyMarkers_17_2_393x852@3x.png
diff --git a/...mages/_64/SnapshotTests.ModalTests/testOneModalOneContainer_17_2_393x852@3x.png b/...mages/_64/SnapshotTests.ModalTests/testOneModalOneContainer_17_2_393x852@3x.png
diff --git a/...4/SnapshotTests.ModalTests/testSingleDirectlySpecifiedModal_17_2_393x852@3x.png b/...4/SnapshotTests.ModalTests/testSingleDirectlySpecifiedModal_17_2_393x852@3x.png
diff --git a/...es/_64/SnapshotTests.ModalTests/testSingleInaccessibleModal_17_2_393x852@3x.png b/...es/_64/SnapshotTests.ModalTests/testSingleInaccessibleModal_17_2_393x852@3x.png
diff --git a/...eferenceImages/_64/SnapshotTests.ModalTests/testSingleModal_17_2_393x852@3x.png b/...eferenceImages/_64/SnapshotTests.ModalTests/testSingleModal_17_2_393x852@3x.png
diff --git a/...erenceImages/_64/SnapshotTests.ModalTests/testTwoContainers_17_2_393x852@3x.png b/...erenceImages/_64/SnapshotTests.ModalTests/testTwoContainers_17_2_393x852@3x.png
diff --git a/.../ReferenceImages/_64/SnapshotTests.ModalTests/testTwoModals_17_2_393x852@3x.png b/.../ReferenceImages/_64/SnapshotTests.ModalTests/testTwoModals_17_2_393x852@3x.png
diff --git a/...shotTests.SwiftUISnapshotTests/testSimpleViewAtSizeThatFits_17_2_393x852@3x.png b/...shotTests.SwiftUISnapshotTests/testSimpleViewAtSizeThatFits_17_2_393x852@3x.png
diff --git a/...mages/_64/SnapshotTests.SwiftUISnapshotTests/testSimpleView_17_2_393x852@3x.png b/...mages/_64/SnapshotTests.SwiftUISnapshotTests/testSimpleView_17_2_393x852@3x.png
diff --git a/.../_64/SnapshotTests.UserInputLabelsTests/testUserInputLabels_17_2_393x852@3x.png b/.../_64/SnapshotTests.UserInputLabelsTests/testUserInputLabels_17_2_393x852@3x.png
diff --git a/Example/SnapshotTests/SnapshotTestCase.swift b/Example/SnapshotTests/SnapshotTestCase.swift
@@ -44,6 +44,7 @@ class SnapshotTestCase: FBSnapshotTestCase {
     // MARK: - Private Static Properties
 
     private static let testedDevices = [
+        TestDeviceConfig(systemVersion: "17.2", screenSize: CGSize(width: 393, height: 852), screenScale: 3),
         TestDeviceConfig(systemVersion: "16.4", screenSize: CGSize(width: 393, height: 852), screenScale: 3),
         TestDeviceConfig(systemVersion: "14.5", screenSize: CGSize(width: 390, height: 844), screenScale: 3),
         TestDeviceConfig(systemVersion: "13.7", screenSize: CGSize(width: 375, height: 812), screenScale: 3),

diff --git a/...shotTests/__Snapshots__/SnapshotTestingTests/testHitTargets.393x852-17-2-3x.png b/...shotTests/__Snapshots__/SnapshotTestingTests/testHitTargets.393x852-17-2-3x.png
diff --git a/...otTests/__Snapshots__/SnapshotTestingTests/testInvertColors.393x852-17-2-3x.png b/...otTests/__Snapshots__/SnapshotTestingTests/testInvertColors.393x852-17-2-3x.png
diff --git a/.../__Snapshots__/SnapshotTestingTests/testMarkerColors.custom-393x852-17-2-3x.png b/.../__Snapshots__/SnapshotTestingTests/testMarkerColors.custom-393x852-17-2-3x.png
diff --git a/...__Snapshots__/SnapshotTestingTests/testMarkerColors.default-393x852-17-2-3x.png b/...__Snapshots__/SnapshotTestingTests/testMarkerColors.default-393x852-17-2-3x.png
diff --git a/...Snapshots__/SnapshotTestingTests/testRenderingMethods.false-393x852-17-2-3x.png b/...Snapshots__/SnapshotTestingTests/testRenderingMethods.false-393x852-17-2-3x.png
diff --git a/..._Snapshots__/SnapshotTestingTests/testRenderingMethods.true-393x852-17-2-3x.png b/..._Snapshots__/SnapshotTestingTests/testRenderingMethods.true-393x852-17-2-3x.png
diff --git a/...ts__/SnapshotTestingTests/testShowingActivationPoint.always-393x852-17-2-3x.png b/...ts__/SnapshotTestingTests/testShowingActivationPoint.always-393x852-17-2-3x.png
diff --git a/...ots__/SnapshotTestingTests/testShowingActivationPoint.never-393x852-17-2-3x.png b/...ots__/SnapshotTestingTests/testShowingActivationPoint.never-393x852-17-2-3x.png
diff --git a/...pshotTestingTests/testShowingActivationPoint.whenOverridden-393x852-17-2-3x.png b/...pshotTestingTests/testShowingActivationPoint.whenOverridden-393x852-17-2-3x.png
diff --git a/.../__Snapshots__/SnapshotTestingTests/testSimpleConfiguration.393x852-17-2-3x.png b/.../__Snapshots__/SnapshotTestingTests/testSimpleConfiguration.393x852-17-2-3x.png
diff --git a/...shots__/SnapshotTestingTests/testSimpleSwiftUIConfiguration.393x852-17-2-3x.png b/...shots__/SnapshotTestingTests/testSimpleSwiftUIConfiguration.393x852-17-2-3x.png
diff --git a/...otTestingTests/testSimpleSwiftUIWithScrollViewConfiguration.393x852-17-2-3x.png b/...otTestingTests/testSimpleSwiftUIWithScrollViewConfiguration.393x852-17-2-3x.png
diff --git a/...ts__/SnapshotTestingTests/testUsingMonochromeSnapshot.false-393x852-17-2-3x.png b/...ts__/SnapshotTestingTests/testUsingMonochromeSnapshot.false-393x852-17-2-3x.png
diff --git a/...ots__/SnapshotTestingTests/testUsingMonochromeSnapshot.true-393x852-17-2-3x.png b/...ots__/SnapshotTestingTests/testUsingMonochromeSnapshot.true-393x852-17-2-3x.png
diff --git a/Scripts/build.swift b/Scripts/build.swift
@@ -46,12 +46,15 @@ enum TaskError: Error {
 }
 
 enum Platform: String, CustomStringConvertible {
+	case iOS_17
 	case iOS_16
 	case iOS_14
 	case iOS_13
 
 	var destination: String {
 		switch self {
+		case .iOS_17:
+			return "platform=iOS Simulator,OS=17.2,name=iPhone 14 Pro"
 		case .iOS_16:
 			return "platform=iOS Simulator,OS=16.4,name=iPhone 14 Pro"
 		case .iOS_14: