Rename module target to Knit and fix example project #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows both SPM and Cocoapods can use `import Knit`
I am now adding Knit as an SPM package dependency, and I removed the previous reference that pulled in all of Knit’s files into the project. Also added a readme and a bootstrap script that creates the CLI executable.
bradfol
force-pushed
the
bradfol/fix-example
branch
from
098f348 to
8250ac5
Compare
bradfol
commented
Jan 10, 2024
| @@ -36,7 +36,6 @@ | |||
| C43334F42A3FDD43003BA9E3 /* ContentView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ContentView.swift; sourceTree = "<group>"; }; | |||
| C43334F62A3FDD44003BA9E3 /* Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = Assets.xcassets; sourceTree = "<group>"; }; | |||
| C43334F92A3FDD44003BA9E3 /* Preview Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = "Preview Assets.xcassets"; sourceTree = "<group>"; }; | |||
| C43335042A3FDD78003BA9E3 /* knit */ = {isa = PBXFileReference; lastKnownFileType = wrapper; name = knit; path = ..; sourceTree = "<group>"; }; | |||
There was a problem hiding this comment.
No longer pulling in the parent directory into the project as a folder reference
bradfol
commented
Jan 10, 2024
Comment on lines
+527
to
+532
| /* Begin XCLocalSwiftPackageReference section */ | ||
| 2C360AE82B4E1A2B00C88B99 /* XCLocalSwiftPackageReference ".." */ = { | ||
| isa = XCLocalSwiftPackageReference; | ||
| relativePath = ..; | ||
| }; | ||
| /* End XCLocalSwiftPackageReference section */ |
There was a problem hiding this comment.
Now using an SPM local package reference
bradfol
commented
Jan 10, 2024
| @@ -230,6 +233,7 @@ | |||
| ); | |||
| inputPaths = ( | |||
| "$(SRCROOT)/KnitExample/KnitExampleAssembly.swift", | |||
| "$(SRCROOT)/KnitExample/KnitExampleUserAssembly.swift", | |||
There was a problem hiding this comment.
Was getting a sandbox error so added the additional input assembly path
skorulis-ap
approved these changes
Jan 10, 2024
|
Fixes #102 |
bradfol
added a commit
that referenced
this pull request
Jan 24, 2024
Needed to update path after previous PR #105
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows both SPM and Cocoapods can use
import KnitI am now adding Knit as an SPM package dependency to the Example project, and I removed the previous reference that pulled in all of Knit’s files into the project.
Also added a readme and a bootstrap script that creates the CLI executable.