Create OptionalAbstractRegistration type #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorulis-ap
force-pushed
the
skorulis/optional-abstract-registration
branch
from
1734a1d to
19d6fd7
Compare
bradfol
approved these changes
Dec 4, 2024
Comment on lines
+79
to
+82
| let string = assembler.resolver.resolve(String?.self) ?? nil | ||
| XCTAssertNil(string) | ||
|
|
||
| let int = assembler.resolver.resolve(Optional<Int>.self) ?? nil |
There was a problem hiding this comment.
Why are there ?? nil on the resolution calls?
There was a problem hiding this comment.
It converts from Int?? to Int?
Co-authored-by: Brad Fol <bradfol@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally when we an abstract registration is created a placeholder during testing that will cause a fatal error making it easier to understand what has gone wrong. But for optional services it's possible to simply return nil and allow tests to continue along normally without the service.