Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type name generation of prefixed names #218

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Improve type name generation of prefixed names #218

merged 1 commit into from
Dec 12, 2024

Conversation

skorulis-ap
Copy link
Collaborator

@skorulis-ap skorulis-ap commented Dec 5, 2024 •
edited
Loading

This better objc style naming where there are multiple capital letters as a prefix NSURLSession isn't quite correct, but it's better than nSURLSession.

@skorulis-ap skorulis-ap marked this pull request as ready for review December 5, 2024 01:50
@skorulis-ap skorulis-ap requested a review from bradfol December 5, 2024 01:52
bradfol
bradfol approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@bradfol bradfol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@skorulis-ap skorulis-ap merged commit 8230f0f into main Dec 12, 2024
1 check passed
@skorulis-ap skorulis-ap deleted the skorulis/prefix-naming branch December 12, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradfol bradfol bradfol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skorulis-ap @bradfol