Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove junit4 dep - not used #2049

Closed
wants to merge 2 commits into from
Closed

Remove junit4 dep - not used #2049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c996933
Remove junit4 dep - not used
chris-ryan-square Jul 14, 2021
b1eed15
Merge branch 'master' into chrisryan-remove-junit4
chris-ryan-square Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion buildSrc/src/main/kotlin/Dependencies.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ object Dependencies {
val jgit = "org.eclipse.jgit:org.eclipse.jgit:5.10.0.202012080955-r"
val jnrUnixsocket = "com.github.jnr:jnr-unixsocket:0.22"
val jooq = "org.jooq:jooq:3.15.0"
val junit4Api = "junit:junit:4.13"
val junitApi = "org.junit.jupiter:junit-jupiter-api:5.6.0"
val junitEngine = "org.junit.jupiter:junit-jupiter-engine:5.6.0"
val junitGradlePlugin = "org.junit.platform:junit-platform-gradle-plugin:1.2.0"
Expand Down
1 change: 0 additions & 1 deletion misk-slack/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ dependencies {
api(project(":wisp-logging"))

testImplementation(Dependencies.assertj)
testImplementation(Dependencies.junit4Api)
testImplementation(Dependencies.junitApi)
testImplementation(Dependencies.junitEngine)
testImplementation(Dependencies.junitParams)
Expand Down
1 change: 0 additions & 1 deletion misk/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ dependencies {
testImplementation(Dependencies.mockitoCore)
testImplementation(project(":misk-metrics-testing"))
testImplementation(project(":misk-testing"))
testImplementation(Dependencies.junit4Api)
testImplementation(Dependencies.assertj)
testImplementation(Dependencies.kotlinTest)
testImplementation(Dependencies.okHttpMockWebServer) {
Expand Down