Bump guice to v6.0.0 and guava to v32.1.1 #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePumpingLemma
force-pushed
the
guice-v6.0.0
branch
2 times, most recently
from
c106784
to
d6deee6
Compare
ThePumpingLemma
commented
Jul 5, 2023
| api(Dependencies.guice) | ||
| api(Dependencies.javaxInject) | ||
| api(Dependencies.tempestTestingInternal) | ||
| api(project(":misk-aws-dynamodb")) | ||
| api(project(":misk-inject")) | ||
| implementation(Dependencies.errorproneAnnotations) |
There was a problem hiding this comment.
I think we can actually omit these if we want, see: google/guice#1739
There was a problem hiding this comment.
If we don't need it, let's remove it.
Could be worth running the dependency analyzer plugin again, last time it caught stuff like this.
There was a problem hiding this comment.
I pushed a change to omit it, let's see if the tests pass. 🤞
chris-ryan-square
approved these changes
Jul 5, 2023
ThePumpingLemma
force-pushed
the
guice-v6.0.0
branch
from
11dc82f
to
408caa8
Compare
keeferrourke
approved these changes
Jul 5, 2023
frojasg
approved these changes
Jul 5, 2023
ThePumpingLemma
force-pushed
the
guice-v6.0.0
branch
from
408caa8
to
1b963b1
Compare
Additionally, use BOMs for both guice and guava
The annotations are not required by Guice at runtime, see google/guice#1739
ThePumpingLemma
force-pushed
the
guice-v6.0.0
branch
from
7b66f9b
to
f2f53e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, use BOMs for both guice and guava