Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AwsSqsJobHandlerSubscriptionService public... #3234

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hamdanjaveed
Copy link
Collaborator

... to allow usage in the service dependency graph

Users may wish to let other Services depend on the AWS JobHandler Subscription service in cases where you want to ensure that SQS job handling has begun before your service has started.

As an alternative to making all these classes open, we could do something like this:

val sqsJobHandlerSubscriptionServiceKey: Key<out Service> = Key.get(AwsSqsJobHandlerSubscriptionService::class.java)

And leave the AwsSqsJobHandlerSubscriptionService and all the rest of the classes marked as internal. Not sure if this would actually work and we'd wanna test this further but from our small injector test it seemed to pass.

... to allow usage in the service dependency graph

Users may wish to let other Services depend on the AWS JobHandler
Subscription service in cases where you want to ensure that SQS job
handling has begun before your service has started.
@frojasg
Copy link
Collaborator

frojasg commented Apr 17, 2024

I would rather expose an interface that has less implementation details. Happy to pair to unblock this.

@notmikedavis
Copy link
Collaborator

Is there anything I can do to help get some movement on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants