Allow an optional CoroutineContext to be supplied to launchMolecule. #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
JakeWharton
approved these changes
Oct 4, 2023
molecule-runtime/src/commonMain/kotlin/app/cash/molecule/molecule.kt
Outdated
Show resolved
Hide resolved
molecule-runtime/src/commonMain/kotlin/app/cash/molecule/molecule.kt
Outdated
Show resolved
Hide resolved
|
Just in case, you might want to rebase on master for the apiDump task would fail otherwise after merge |
Rebased onto master. |
ghost
commented
Oct 6, 2023
molecule-runtime/src/commonMain/kotlin/app/cash/molecule/molecule.kt
Outdated
Show resolved
Hide resolved
JakeWharton
reviewed
Oct 25, 2023
Comment on lines
+27
to
+28
| public static final synthetic fun launchMolecule (Lkotlinx/coroutines/CoroutineScope;Lapp/cash/molecule/RecompositionMode;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function2;)V | ||
| public static final synthetic fun launchMolecule (Lkotlinx/coroutines/CoroutineScope;Lapp/cash/molecule/RecompositionMode;Lkotlin/jvm/functions/Function2;)Lkotlinx/coroutines/flow/StateFlow; |
There was a problem hiding this comment.
This diff and the tool that produces it are really subpar, but these two lines are the same as the ones which were deleted except with synthetic added (i.e., hiding them solely for binary compatibility). The new source-compatible versions are the two lines above and the synthetic functions for supporting their default argument values are the two lines below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow an optional CoroutineContext to be supplied to launchMolecule.
This allows easier control of what dispatcher Molecule should run under in cases where we can't presume it's wired correctly in the provided CoroutineScope.