ktlint 1.0 #324
Merged
ktlint 1.0 #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and its terrible function naming rule that doesn't honor Compose conventions!
mattprecious
approved these changes
Oct 25, 2023
| @@ -36,8 +36,8 @@ import org.jetbrains.kotlin.gradle.plugin.KotlinSourceSet.Companion.COMMON_MAIN_ | |||
| import org.jetbrains.kotlin.gradle.plugin.SubpluginArtifact | |||
| import org.jetbrains.kotlin.gradle.plugin.SubpluginOption | |||
|
|
|||
| private const val extensionName = "molecule" | |||
| private const val moleculeRuntime = "app.cash.molecule:molecule-runtime:$moleculeVersion" | |||
| private const val EXTENSION_NAME = "molecule" | |||
There was a problem hiding this comment.
Yeah I hate it, but https://kotlinlang.org/docs/coding-conventions.html#property-names
Goooler
reviewed
Oct 26, 2023
| ktlint = "com.pinterest:ktlint:0.50.0" | ||
| ktlint = "com.pinterest.ktlint:ktlint:1.0.1" |
There was a problem hiding this comment.
This should be "com.pinterest.ktlint:ktlint-cli:1.0.1" for now, see https://github.com/pinterest/ktlint/releases/tag/1.0.0
There was a problem hiding this comment.
Want to send a PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and its terrible function naming rule that doesn't honor Compose conventions!
Closes #322