Proposed fix to correct Compose UI animations #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-powell
force-pushed
the
gpowell/compose/animation-timing
branch
2 times, most recently
from
1e15599 to
b3babf7
Compare
geoff-powell
force-pushed
the
gpowell/compose/animation-timing
branch
from
b3babf7 to
3079a30
Compare
geoff-powell
changed the title
BrianGardnerAtl
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So animations with
offsetMillisdidn't work properly in paparazzi. This was due to the Transition apis tracking thestartTimeNanoswhen a transition starts. Since this is set ahead of the transition, the delta to render the frame was always 0. Forgif()methods that usedstart = 0they render correctly because the starting frame is at0nanos.The best way I could combat this was for cases in Compose where the caller was manually setting the
startNanosforPaparazzi.takeSnapshots()I call multiple render calls with time 0 to ensure Transition apis havestartTimeNanos = 0Fixes #627 #678