Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't scale accessibility legend text when font scale is non-default #1760

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't scale accessibility legend text when font scale is non-default #1760

wants to merge 1 commit into from
+13 −8

Conversation

colinmarsch
Copy link
Contributor

Resolves #1660

@colinmarsch
Copy link
Contributor Author

colinmarsch commented Dec 19, 2024 •
edited
Loading

  • Need to add a test case that runs this new test class before merging

@colinmarsch colinmarsch force-pushed the cmarsch/2024-12-18/dont-scale-accessibility-legend-text branch from e0efad5 to 43d74a5 Compare December 19, 2024 15:32
jrodbx
jrodbx approved these changes Dec 20, 2024
View reviewed changes
paparazzi-gradle-plugin/src/test/java/app/cash/paparazzi/gradle/PaparazziPluginTest.kt Outdated
val fixtureRoot = File("src/test/projects/scaled-a11y")
gradleRunner
.withArguments("verifyPaparazziDebug", "--stacktrace")
.runFixture(fixtureRoot) { build() }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we merge this into ComposeA11yTest + use unsafeUpdateConfig? imo, it's more obvious/readable to keep all A11y tests in the same project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That suggestion sounds good to me, just updated this PR

@colinmarsch colinmarsch force-pushed the cmarsch/2024-12-18/dont-scale-accessibility-legend-text branch from 43d74a5 to 4f85342 Compare December 21, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodbx jrodbx jrodbx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Font scaling applies to the text in the legend when using AccessibilityRenderExtension
2 participants
@colinmarsch @jrodbx