Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce LeakWatcherRule to monitor Paparazzi leaks #431

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Introduce LeakWatcherRule to monitor Paparazzi leaks #431

wants to merge 1 commit into from

Conversation

jrodbx
Copy link
Collaborator

@jrodbx jrodbx commented May 26, 2022 •
edited
Loading

POC to help figure out situations like Compose Runtime leaks.

To run, ./gradlew paparazzi-gradle-plugin:test --tests=app.cash.paparazzi.gradle.PaparazziPluginTest.compose

in conjunction with modifications to either:

  • Paparazzi#forceReleaseComposeReferenceLeaks (to test potential fixes to Compose runtime leaks!)
  • paparazzi-gradle-plugin/src/test/projects/compose/src/test/java/app/cash/paparazzi/plugin/test/ComposeTest.kt (to try new Composables which may surface other leaks!)

@pyricau
Copy link

pyricau commented May 26, 2022

Love it

@pyricau pyricau mentioned this pull request May 26, 2022
Open
@jrodbx jrodbx force-pushed the jrod/2022-05-26/leak-detection-test branch from 086edc3 to bc2b2c8 Compare May 26, 2022 20:13
@geoff-powell
Copy link
Collaborator

Nice 👍🏽

@jrodbx jrodbx force-pushed the jrod/2022-05-26/leak-detection-test branch 2 times, most recently from 530dc22 to 954ed55 Compare May 26, 2022 20:37
@jrodbx jrodbx force-pushed the jrod/2022-05-25/nuke-compose-leaks branch from b3f745e to 2f30436 Compare May 26, 2022 20:37
@jrodbx jrodbx force-pushed the jrod/2022-05-26/leak-detection-test branch from 954ed55 to 44cb1d0 Compare May 26, 2022 20:38
@jrodbx jrodbx force-pushed the jrod/2022-05-25/nuke-compose-leaks branch from 2f30436 to 9a2deb9 Compare May 26, 2022 20:59
@jrodbx jrodbx force-pushed the jrod/2022-05-26/leak-detection-test branch from 44cb1d0 to 00c68dc Compare May 26, 2022 20:59
Base automatically changed from jrod/2022-05-25/nuke-compose-leaks to master May 26, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrodbx @pyricau @geoff-powell