New ZiplineTreehouseUi.Host bridges all host functions #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment we've got 4 host functions offered to each UI. In a follow-up I'd like to introduce a 5th. I'd like the process of adding a 5th to not require yet another start() overload, so I'm introducing this type to make additional features easier to add later.
swankjesse
commented
Oct 27, 2023
redwood-treehouse-host/src/commonMain/kotlin/app/cash/redwood/treehouse/TreehouseAppContent.kt
Show resolved
Hide resolved
| public val stateSnapshot: StateSnapshot? | ||
|
|
||
| public fun addOnBackPressedCallback(callback: OnBackPressedCallbackService): CancellableService | ||
| } |
There was a problem hiding this comment.
Strictly speaking introducing this Host abstraction is a bit less efficient than passing the 4 parameters inline. This is because we need an extra 2 host-guest bridges for the two value parameters (uiConfigurations and stateSnapshot) that were originally passed by value into start(). I think this is a good tradeoff for simplicity.
|
Part of #1458 |
veyndan
reviewed
Oct 31, 2023
...treehouse/src/commonMain/kotlin/app/cash/redwood/treehouse/OnBackPressedDispatcherService.kt
Outdated
Show resolved
Hide resolved
veyndan
reviewed
Oct 31, 2023
redwood-treehouse/src/commonMain/kotlin/app/cash/redwood/treehouse/ZiplineTreehouseUi.kt
Show resolved
Hide resolved
veyndan
approved these changes
Oct 31, 2023
|
Good call. Done. |
JakeWharton
approved these changes
Oct 31, 2023
redwood-treehouse-guest/src/commonMain/kotlin/app/cash/redwood/treehouse/treehouseCompose.kt
Outdated
Show resolved
Hide resolved
…/treehouse/treehouseCompose.kt Co-authored-by: Jake Wharton <jw@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we've got 4 host functions offered to each UI. In a follow-up I'd like to introduce a 5th. I'd like the process of adding a 5th to not require yet another start() overload, so I'm introducing this type to make additional features easier to add later.