Fix a bug where modifiers' effects continue after they're removed #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
commented
Sep 27, 2024
There was a problem hiding this comment.
We already had a test that demonstrated that our behavior was incorrect!
swankjesse
commented
Sep 27, 2024
| if (newRequestedMaxHeight neq oldRequestedMaxHeight) requestedMaxHeight = newRequestedMaxHeight | ||
| if (newFlexGrow neq oldFlexGrow) flexGrow = newFlexGrow | ||
| if (newFlexShrink neq oldFlexShrink) flexShrink = newFlexShrink | ||
| if (newFlexBasis neq oldFlexBasis) flexBasis = newFlexBasis |
There was a problem hiding this comment.
JakeWharton
approved these changes
Sep 27, 2024
|
Linked from modifier removal detection issue. No one should have to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md's "Unreleased" section has been updated, if applicable.