Introduce pluggable backend cache for the HTTP layer. #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right now, I have implemented two storage systems, Memory and Redis. I think a 3rd option would be useful as well, a mix of both, where Redis is used to synchronize local cache between N nodes, but the caching is always local. I can work on a prototype if this sounds like a good idea. /cc @callebtc @thesimplekid |
crodas
force-pushed
the
cache-with-custom-backend
branch
3 times, most recently
from
e7efec3 to
d80a7bb
Compare
|
I made redis optional now @thesimplekid |
thesimplekid
requested changes
Dec 10, 2024
thesimplekid
requested changes
Dec 12, 2024
There was a problem hiding this comment.
I added a redis container to the docker-compose and the ability to read the cache config from env vars. But @crodas can you take a look at what is causing the panic I noted.
crodas
force-pushed
the
cache-with-custom-backend
branch
from
6a96e9d to
333159a
Compare
thesimplekid
requested changes
Dec 16, 2024
thesimplekid
changed the title
Co-authored-by: thesimplekid <tsk@thesimplekid.com>
1. Remove `new` from trait, it made no sense, added a function to modify the ttl and tti instead 2. Removed `unwrap` and add logs instead
crodas
force-pushed
the
cache-with-custom-backend
branch
from
333159a to
a26bb7a
Compare
Use a more rusty expr instead of match
crodas
force-pushed
the
cache-with-custom-backend
branch
from
9d83391 to
8f3104f
Compare
thesimplekid
approved these changes
Dec 17, 2024
vnprc
pushed a commit
to vnprc/cdk
that referenced
this pull request
Dec 18, 2024
--------- Co-authored-by: thesimplekid <tsk@thesimplekid.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #478.
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
Add support for custom storages for the HTTP cache layer.
REMOVED
FIXED
Checklist
just final-checkbefore committing