Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spring-configuration-metadata.json generated by spring boot configuration processor instead of manually creating it #417

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

genuss
Copy link

@genuss genuss commented Dec 22, 2024

Hello!

I've just come across your project and so far I love it! While browsing through the code I found that you don't use spring-boot-configuration-processor to generate configuration properties netdata. Is it intentional? If not, I'd like to propose a small contribution. Instead of writing these files manually, it's better to have them generated from javadocs. This have some advantages:

  • less code overalll.
  • less error-prone. For example, the file for spring boot 2 states there is a gg.jte.development-mode property. This is not the case though, it's only supported in spring boot 3.
  • Users of intellij idea community edition can see documentation by reading javadocs. As far as I understand, reading of ...metadata.json` files is an ultimate-only feature.

What do you think about it?

…guration processor instead of manually creating it
@casid
Copy link
Owner

casid commented Jan 3, 2025

Welcome @genuss and thanks for the heads up!

I'm not very deep into Spring, so can't really give you meaningful feedback.

@atomfrede what's your opinion on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants