Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node20 #33

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Use node20 #33

merged 1 commit into from
Apr 12, 2024

Conversation

porras
Copy link
Contributor

@porras porras commented Apr 11, 2024

Hi!

Currently this actions shows a warning about the node version:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: conao3/setup-cask@master. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

I'm not familiar with the code of this action so maybe this change is too simplistic, but what I can say is that I pointed a package I maintain to my fork and it worked fine (and the warning is no longer there): https://github.com/porras/evil-ruby-text-objects/actions/runs/8646977431

@jcs090218
Copy link
Member

Thanks for the changes!

cc @conao3

@conao3
Copy link
Member

conao3 commented Apr 12, 2024

yes, I think this change is reasonable.
I worried about regression happening, though.
I'll have to add tests. Well, I'll merge them once.

@conao3 conao3 merged commit 4e417b5 into cask:master Apr 12, 2024
@conao3
Copy link
Member

conao3 commented Apr 12, 2024

Good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants