Interaction with Casper smart-contract source code verification service for feat-2.0 branch

[wojcik91]

Port of changes from https://github.com/casper-ecosystem/casper-client-rs/pull/144/files adjusted to be merged into the branch tracking Node version 2.0

[gRoussac]

@wojcik91 can you please pull feat-track-2.0 to remove that removes vergen dependency ?

[wojcik91]

@gRoussac I applied your review suggestions.

[gRoussac]

@wojcik91 I need to checkout your branch to see what clippy complains about

error: package `clap_lex v0.7.2` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.73.0
Error: Either upgrade to rustc 1.74 or newer, or use
cargo update -p clap_lex@0.7.2 --precise ver
where `ver` is the latest version of `clap_lex` supporting rustc 1.73.0

[gRoussac]

@wojcik91 I think the best would be to bump the toolchain as per casper-node setting

Please make this change reviewed by @mpapierski

teonite#3

[wojcik91]

@wojcik91 I think the best would be to bump the toolchain as per casper-node setting

Please make this change reviewed by @mpapierski

teonite#3

I merged the update and it seems that locally it works now.

Just out of curiosity - is there a specific reason why this project is not using a lockfile? Previously I did not notice this issue because this specific dependency was at 0.6.0 in my Cargo.lock.

[wojcik91]

I see the test failure, will resolve.

[gRoussac]

Just out of curiosity - is there a specific reason why this project is not using a lockfile? Previously I did not notice this issue because this specific dependency was at 0.6.0 in my Cargo.lock.

it's a long debate I have no opinion, I think committing lock files either rust or npm has pros and cons. Right now we have it on casper-node, not on the client, the client is more simple it should just pass CI/CD with cargo update in any case. We can not decide this for your PR but it might be considered I guess.

[wojcik91]

Just out of curiosity - is there a specific reason why this project is not using a lockfile? Previously I did not notice this issue because this specific dependency was at 0.6.0 in my Cargo.lock.

it's a long debate I have no opinion, I think committing lock files either rust or npm has pros and cons. Right now we have it on casper-nod, not on the client, the client is more simple it should just pass CI/CD with cargo update in any case. We can not decide this for your PR but it might be considered I guess.

Sure, I certainly don't aim to convince anyone to make any sweeping changes as part of this PR :)
Just thought there was some project-specific reason I did not consider since it seems unorthodox.

[gRoussac]

@wojcik91 Please review/merge this PR teonite#5