Introduced keep alive monitor mechanism in the binary port. Introduce… #4958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d two new config properties for the binary port: keepalive_check_interval, keepalive_no_activity_timeout. From now on if a binary port connection is not used for a configured period of time it will be closed on the node side. Introduced a binary request variant BinaryRequest::KeepAliveRequest so that clients that want to keep the connection alive can use this low-overhead way to do that.
zajko
requested review from
EdHastingsCasperAssociation and
darthsiroftardis
zajko
commented
Nov 14, 2024
| let entity_hash_addr: HashAddr = PackageAddr::try_from(package_addr_bytes.as_ref()) | ||
| .map_err(|error| FromStrError::Package(error.to_string()))?; | ||
| return Ok(Key::State(EntityAddr::SmartContract(entity_hash_addr))); | ||
| if let Some(entity_addr_formatted) = input.strip_prefix(STATE_PREFIX) { |
There was a problem hiding this comment.
I piggy backed this change because it makes sidecars tests fail.
I consulted with @mpapierski that deserialising always to Key::State(EntityAddr::SmartContract) is a bug, so I changed it that it will consider all EntityAddr possibilities.
darthsiroftardis
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d two new config properties for the binary port: keepalive_check_interval, keepalive_no_activity_timeout. From now on if a binary port connection is not used for a configured period of time it will be closed on the node side. Introduced a binary request variant BinaryRequest::KeepAliveRequest so that clients that want to keep the connection alive can use this low-overhead way to do that.