-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid cancel_reservations args #5016
Fix invalid cancel_reservations args #5016
Conversation
resolves #5006 |
@wojcik91 there seems to be still a mismatch between expected arguments at different layers. Here, the node is looking for I guess it should be |
That's correct, thanks for pointing it out. |
bors r+ |
4988: GH-4985: Transaction vm2 settings r=mpapierski a=mpapierski Transaction settings valid only for VM2 are stored in an enum. This solves situation when transaction target has specified extra values that will not be used by VM1 runtime. Closes #4985 5016: Fix invalid cancel_reservations args r=zajko a=wojcik91 Fix `cancel_reservations` args typing in remaining places. Co-authored-by: Michał Papierski <michal@casper.network> Co-authored-by: Ed Hastings <ed@casper.network> Co-authored-by: Michał Papierski <michal@papierski.net> Co-authored-by: Maciej Wójcik <maciek@wjck.pl>
This PR was included in a batch that successfully built, but then failed to merge into feat-2.0. It will not be retried. Additional information: {"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"} |
bors r+ |
Build failed: |
bors r+ |
Build succeeded: |
a7ce99c
into
casper-network:feat-2.0
Fix
cancel_reservations
args typing in remaining places.