Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid cancel_reservations args #5016

Conversation

wojcik91
Copy link
Collaborator

@wojcik91 wojcik91 commented Dec 9, 2024

Fix cancel_reservations args typing in remaining places.

@wojcik91
Copy link
Collaborator Author

wojcik91 commented Dec 9, 2024

resolves #5006

@davidatwhiletrue
Copy link

@wojcik91 there seems to be still a mismatch between expected arguments at different layers.

Here, the node is looking for delegator_kinds input argument:

https://github.com/teonite/casper-node/blob/122bbe995ae4f2ef817238c010ba40487d242ba9/storage/src/data_access_layer/auction.rs#L310

I guess it should be delegators instead to match auction contract interface.

@wojcik91
Copy link
Collaborator Author

@wojcik91 there seems to be still a mismatch between expected arguments at different layers.

Here, the node is looking for delegator_kinds input argument:

https://github.com/teonite/casper-node/blob/122bbe995ae4f2ef817238c010ba40487d242ba9/storage/src/data_access_layer/auction.rs#L310

I guess it should be delegators instead to match auction contract interface.

That's correct, thanks for pointing it out.

@zajko
Copy link
Contributor

zajko commented Dec 10, 2024

bors r+

casperlabs-bors-ng bot added a commit that referenced this pull request Dec 10, 2024
4988: GH-4985: Transaction vm2 settings r=mpapierski a=mpapierski

Transaction settings valid only for VM2 are stored in an enum. This solves situation when transaction target has specified extra values that will not be used by VM1 runtime.

Closes #4985 

5016: Fix invalid cancel_reservations args r=zajko a=wojcik91

Fix `cancel_reservations` args typing in remaining places.


Co-authored-by: Michał Papierski <michal@casper.network>
Co-authored-by: Ed Hastings <ed@casper.network>
Co-authored-by: Michał Papierski <michal@papierski.net>
Co-authored-by: Maciej Wójcik <maciek@wjck.pl>
Copy link
Contributor

This PR was included in a batch that successfully built, but then failed to merge into feat-2.0. It will not be retried.

Additional information:

{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"}

@zajko
Copy link
Contributor

zajko commented Dec 10, 2024

bors r+

casperlabs-bors-ng bot added a commit that referenced this pull request Dec 10, 2024
5016: Fix invalid cancel_reservations args r=zajko a=wojcik91

Fix `cancel_reservations` args typing in remaining places.


Co-authored-by: Maciej Wójcik <maciek@wjck.pl>
Copy link
Contributor

Build failed:

@zajko
Copy link
Contributor

zajko commented Dec 11, 2024

bors r+

Copy link
Contributor

Build succeeded:

@casperlabs-bors-ng casperlabs-bors-ng bot merged commit a7ce99c into casper-network:feat-2.0 Dec 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants