Execution engine changelog #5046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zajko
commented
Dec 19, 2024
| @@ -6,13 +6,12 @@ use serde::{Deserialize, Serialize}; | |||
|
|
|||
| #[cfg(test)] | |||
| use rand::Rng; | |||
| use schemars::JsonSchema; | |||
There was a problem hiding this comment.
In my mind introducing schemars to binary_port is overkill just to save a few lines of code in sidecar so I removed it
… in StoredValue::SmartContract, applying minor code fixes
zajko
force-pushed
the
execution_engine_changelog
branch
from
7e13470 to
fdb831a
Compare
zajko
requested review from
EdHastingsCasperAssociation and
mpapierski
and removed request for
EdHastingsCasperAssociation
…est linkme against 1.77.2 clippy
EdHastingsCasperAssociation
approved these changes
Dec 20, 2024
|
bors r+ |
|
Build succeeded: |
casperlabs-bors-ng
bot
merged commit 7ce0125
into
casper-network:feat-2.0
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backfilling execution_engine backlog. Fixing json serialization issue in StoredValue::SmartContract, applying minor code fixes