Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aarch64: fix mobile rendering issues #38

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions .github/workflows/flatpak.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ concurrency:
cancel-in-progress: true

jobs:
flatpak:
name: Flathub
flathub_x86_64:
name: Flathub (x86_64)
runs-on: ubuntu-latest
container:
image: ghcr.io/flathub-infra/flatpak-github-actions:gnome-46
Expand All @@ -23,3 +23,31 @@ jobs:
bundle: butler.flatpak
manifest-path: com.cassidyjames.butler.json
cache-key: "flatpak-builder-${{ github.sha }}"

flathub_aarch64:
name: Flathub (aarch64)
if: ${{ startsWith( github.event.pull_request.title, 'aarch64' ) }}
runs-on: ubuntu-latest
container:
image: ghcr.io/flathub-infra/flatpak-github-actions:gnome-46
options: --privileged
steps:
- uses: actions/checkout@v4
# Docker is required by the docker/setup-qemu-action which enables emulation
- name: Install deps
run: |
# Use the static binaries because it's unable to use a package manager
curl https://download.docker.com/linux/static/stable/x86_64/docker-26.0.0.tgz --output ./docker.tgz
tar xzvf docker.tgz
mv docker/* /usr/bin
- name: Set up QEMU
id: qemu
uses: docker/setup-qemu-action@v3
with:
platforms: arm64
- uses: flathub-infra/flatpak-github-actions/flatpak-builder@master
with:
bundle: butler.flatpak
manifest-path: com.cassidyjames.butler.json
cache-key: "flatpak-builder-${{ github.sha }}"
arch: aarch64
2 changes: 1 addition & 1 deletion meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ executable(
meson.project_name(),
'src' / 'App.vala',
'src' / 'MainWindow.vala',
'src' / 'Widgets' / 'WebView.vala',
'src' / 'WebView.vala',
asresources,
config_file,
dependencies: [
Expand Down
10 changes: 5 additions & 5 deletions src/Widgets/WebView.vala → src/WebView.vala
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ public class Butler.WebView : WebKit.WebView {

var webkit_settings = new WebKit.Settings () {
default_font_family = Gtk.Settings.get_default ().gtk_font_name,
enable_back_forward_navigation_gestures = true,
// enable_back_forward_navigation_gestures = true,
enable_developer_extras = is_terminal,
enable_dns_prefetching = true,
enable_html5_database = true,
enable_html5_local_storage = true,
enable_smooth_scrolling = true,
enable_webgl = true,
enable_webrtc = true,
hardware_acceleration_policy = WebKit.HardwareAccelerationPolicy.ALWAYS
// enable_smooth_scrolling = true,
// enable_webgl = true,
// enable_webrtc = true,
// hardware_acceleration_policy = WebKit.HardwareAccelerationPolicy.ALWAYS
};

settings = webkit_settings;
Expand Down