Jkeller/robot dockerfile bugfix #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ausing necessary ros2 packages from being automatically removed, breaking the build. This issue doesn't happen when libimath-dev is installed on the jetsons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sim Robot Dockerfile Bug Fix
The package libimath-dev had to be installed on the Jetsons to build the code. When this package was installed in the sim robot docker image, it had a side effect of automatically removing some necessary ros2 packages and some other packages which were causing the colcon build to fail. I added an argument and if statement to the dockerfile so that we can run sim specific and real robot specific commands during the build.