KUBE-856: Support http proxy config #96
Merged
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trojan295
approved these changes
Feb 3, 2025
| @@ -1,5 +1,6 @@ | |||
| locals { | |||
| configuration_id_regex_pattern = "[a-zA-Z0-9]{8}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{4}-[a-zA-Z0-9]{12}" | |||
| has_http_proxy = length(var.no_proxy) > 0 || (var.http_proxy != null && var.http_proxy != "") || (var.https_proxy != null && var.https_proxy != "") | |||
There was a problem hiding this comment.
How does the module behave in case of just setting a no_proxy address, but keeping the http_proxy and https_proxy empty?
In theory setting no_proxy without a proxy should do nothing.
There was a problem hiding this comment.
Yes, specifying only no_proxy would be no-op but we still pass the value downstream. Don't make sense to be fancy imo, user might have a reason to do this 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on terraform provider being released first - see castai/terraform-provider-castai#448 .