Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to docs for contributing.
FWIW, I use conda instead of virtualenv. So I was able to set up with
instead of
mkvirtualenv cotede
.After that, all steps were the same.
flake8 was not in the requirements list anywhere, so I added that to
test-requirements.txt
and added a step to install the libs in that file.I was able to run the tests described:
However there are a lot of flake8 failures. I recommend resolving those and/or adding a list of ignored tests to
flake8-ignore
. Otherwise, as a contributor I'd just ignore this.Ref: openjournals/joss-reviews#2063