Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: contributing updates #38

Closed

Conversation

jessicaaustin
Copy link

Updates to docs for contributing.

FWIW, I use conda instead of virtualenv. So I was able to set up with

conda create -y -n cotede37 python=3.7
conda activate cotede37

instead of mkvirtualenv cotede.

After that, all steps were the same.

flake8 was not in the requirements list anywhere, so I added that to test-requirements.txt and added a step to install the libs in that file.

I was able to run the tests described:

$ flake8 cotede tests
$ py.test tests
$ tox

However there are a lot of flake8 failures. I recommend resolving those and/or adding a list of ignored tests to flake8-ignore. Otherwise, as a contributor I'd just ignore this.

Ref: openjournals/joss-reviews#2063

@castelao
Copy link
Owner

Thanks @jessicaaustin . CoTeDe has been available at conda for some time now. As I mentioned before, I removed the requirement on running flake8 for now and I've been slowly refactoring/re-organizing the code. Unfortunately, parts of the code pre-date black and flake8, but I'm working on that. Thank you.

@castelao castelao closed this Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants