-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make readonly parameters detection more robust #406
Make readonly parameters detection more robust #406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me.
-
The optimization in
CopyOutAndRefParameters
looks good to me. -
I do have a few reservations about some (seemingly unnecessary) changes in
IsReadOnly
(and.gitignore
), nothing major though. -
Please ensure that, however the code eventually ends up, the longish introductory code comment in
IsReadOnly
actually agrees with (is in sync with) what the code does!
Thank you for working on this!
0fa3914
to
845e55d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
Just two more suggestions: one is stated in the review comment below, the other would be to mention this improvement in the CHANGELOG.md
(this PR's title should be sufficient as a summary). (Sorry for not thinking of these earlier.)
80f2b62
to
5a41f9a
Compare
@stakx @jonorossi Many thanks for the code review and the valuable comments you left! Appreciate a lot 🍻 🙇 I fixed all of them, so we should be fine to proceed further. Let me know if something left. P.S. Sorry for the "laconic" replies and "dirty" commits - am extremely busy these days 😖 |
Check custom modifiers, so if they are present - recognize read-only parameters.
5a41f9a
to
aa27233
Compare
@jonorossi @stakx Are we waiting for somebody else's approve to merge this? Unfortunately, I don't have enough permissions to run the merge... |
Sorry for being non-responsive for the last few days, I was feeling a little ill & took things more slowly. Good that this has been merged, thanks for the improvements!! |
@stakx not a problem, I hope you are feeling better. |
@stakx Recover soon, mate 😉 Thanks for the time spent on this. |
Closes #398
Now we check the
In
required modifier, so the detection logic is more robust.Additional improvements:
I've tested that it's much quicker to test for the custom modifiers, than for attributes.
Test body:
Result:
CC @stakx