-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract abstract base class BaseInterfaceProxyGenerator
#550
Extract abstract base class BaseInterfaceProxyGenerator
#550
Conversation
06b1b55
to
f8972d6
Compare
f8972d6
to
7e19df6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legend 🥇 . That mess has annoyed me for years, but I've never attempted to clean it up because it always seemed like there were so many small differences between each generator.
Thanks for making it so easy to code review.
Same general feeling here. And there are probably similar opportunities remaining, in fact the two new base proxy generator classes share quite a few bits in common. It seems entirely possible to eventually merge them right into |
Probably need more composition and less inheritance. The changes you made to separate one contributor into 3 for their specific tasks is probably more the direction things should go. |
This is similar to my previous PR #549 which extracted a base class for class proxy generators. Only this time, we start off with extracting the base class, then
InterfaceProxyWithTargetGenerator
specifics are pushed into the subtype.Again, the commits represent single edit steps (for easier reviewing), they can be squashed when merging.