Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CreateClassProxy overloads using typeparams #636

Merged
merged 5 commits into from
Jan 12, 2023

Conversation

backstromjoel
Copy link
Contributor

No description provided.

@stakx stakx mentioned this pull request Dec 29, 2022
@backstromjoel backstromjoel requested review from jonorossi and stakx and removed request for jonorossi and stakx January 11, 2023 12:38
@stakx
Copy link
Member

stakx commented Jan 11, 2023

@backstromjoel, your new changes to IProxyGenerator cause changes to the ref/ contract files. You'll need to re-commit those too to get CI to pass.

@backstromjoel
Copy link
Contributor Author

@backstromjoel, your new changes to IProxyGenerator cause changes to the ref/ contract files. You'll need to re-commit those too to get CI to pass.

Will fix tomorrow, thanks for the quick feedback. I'm new to the whole open source thing so thanks for keeping your patience :)

@stakx
Copy link
Member

stakx commented Jan 11, 2023

No worries, you're doing well so far! Your contribution is appreciated. And tomorrow's soon enough, you don't need to rush. :-)

@jonorossi jonorossi merged commit d7e398f into castleproject:master Jan 12, 2023
@jonorossi jonorossi added this to the vNext milestone Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants