Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve support for covariant returns (where generic types are involved) #643

Merged
merged 9 commits into from
Dec 29, 2022
Merged

Improve support for covariant returns (where generic types are involved) #643

merged 9 commits into from
Dec 29, 2022

Commits on Dec 29, 2022

  1. Add passing test for proxying empty generic record type

    @stakx
    stakx committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    1f6905e View commit details
    Browse the repository at this point in the history

  2. Add failing test for proxying type derived from generic record type

    @stakx
    stakx committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    2d944e4 View commit details
    Browse the repository at this point in the history

  3. Detail: adjust names of derived record types 

    (The type name `DerivedEmptyGenericRecord` suggests that it is generic,
which is not the case; `DerivedFromEmptyGenericRecord` is more accurate.
For consistency, let's apply the same name change to `EmptyRecord` and
its subtype.)
    @stakx
    stakx committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    06884f4 View commit details
    Browse the repository at this point in the history

  4. Also check for covariant return types if one of them is generic

    @stakx
    stakx committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    6238c15 View commit details
    Browse the repository at this point in the history

  5. Detail: assert that IsCovariantReturnTypes only gets called for ret… 

    …urn types
    @stakx
    stakx committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    ee08309 View commit details
    Browse the repository at this point in the history

  6. Add failing tests for covariant return types involving a variant gene… 

    …ric interface
    @stakx
    stakx committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    be22332 View commit details
    Browse the repository at this point in the history

  7. Also check for covariant return types if both of them are generic

    @stakx
    stakx committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    a1b44d7 View commit details
    Browse the repository at this point in the history

  8. Move check for covariant return types 

    Performing this check for anything other than return types is basically
wasted time, so moving it to `EqualReturnTypes` means it will only run
when actually needed.
    @stakx
    stakx committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    eda2c80 View commit details
    Browse the repository at this point in the history

  9. Update changelog

    @stakx
    stakx committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    6b16135 View commit details
    Browse the repository at this point in the history