Fix ArgumentException caused by Enum constraint on method out parameter
#658
+50
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
force-pushed
the
bug/generic-enum-constraint
branch
from
37c3a55
to
80fd65d
Compare
|
@castleproject/committers, this too should be a fairly straightforward bug fix. Leaving it open for review for a week or two, without feedback I'll go ahead and merge it after that. |
jonorossi
approved these changes
Aug 24, 2023
This triggers a `ArgumentException`: "Cannot create an instance of `TEnum` because `Type.ContainsGenericParameters` is true."
* As the previous commit showed, the `IsGenericParameter` check must have priority... probably not just over enums, but over any other value types, too. * The `IsEnum` check can be put behind `IsValueType` so it does not run for non-value types.
stakx
force-pushed
the
bug/generic-enum-constraint
branch
from
80fd65d
to
1bc7f18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #656.