Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize array usage, plus other minor tweaks #688

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Henr1k80
Copy link
Contributor

@Henr1k80 Henr1k80 commented Oct 14, 2024

Avoid array allocations, where possible, part of #687 (excluding DictionaryAdapter)
Plus other minor tweaks

Copy link
Member

@stakx stakx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me!

src/Castle.Core/Core/Resource/CustomUri.cs Show resolved Hide resolved
@stakx stakx merged commit f372c2c into castleproject:master Oct 15, 2024
4 checks passed
@stakx
Copy link
Member

stakx commented Oct 15, 2024

Thank you for contributing, @Henr1k80!

@Henr1k80 Henr1k80 deleted the no-empty-array-allocation branch October 16, 2024 06:37
@stakx stakx added this to the vNext milestone Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants