Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings regarding non-existent package #326

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Fix warnings regarding non-existent package #326

merged 1 commit into from
Sep 11, 2017

Conversation

jonorossi
Copy link
Member

Update minimum Castle Core version to 4.1.0 to fix package restore
warnings that turn into errors (resulting in build failure) because the
version of System.ComponentModel.TypeConverter referenced by Castle
Core does not exist.

Fixes #321

Update minimum Castle Core version to 4.1.0 to fix package restore
warnings that turn into errors (resulting in build failure) because the
version of System.ComponentModel.TypeConverter referenced by Castle
Core does not exist.
@jonorossi jonorossi added this to the vNext milestone Sep 11, 2017
@jonorossi
Copy link
Member Author

This change fixes the failed compilation, however introduces some failing unit tests because the assembly version of the Castle Core assemblies is no longer 4.0.0.0. We need to get castleproject/Core#288 fixed and released, and bump the minimum version again otherwise consumers of Windsor will run into these errors on .NET Framework, we don't want users to have to deal with binding redirects.

Castle.MicroKernel.SubSystems.Conversion.ConverterException : Could not convert string 'Castle.Services.Logging.Log4netIntegration.ExtendedLog4netFactory,Castle.Services.Logging.Log4netIntegration,Version=4.0.0.0, Culture=neutral,PublicKeyToken=407dd0808d44fbdc' to a type.
----> System.IO.FileLoadException : Could not load file or assembly 'Castle.Services.Logging.Log4netIntegration, Version=4.0.0.0, Culture=neutral, PublicKeyToken=407dd0808d44fbdc' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)

@jonorossi jonorossi merged commit 5df1e1f into master Sep 11, 2017
@jonorossi jonorossi deleted the fix-build branch September 11, 2017 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Master build is broken: error NU1603
1 participant