Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceDocument refactor for separate raw field #1054

Merged
merged 4 commits into from
Mar 23, 2020
Merged

Conversation

edwinzhng
Copy link
Member

Addresses #1048

Made the SourceDocument an abstract class so that we can have a separate raw() function that returns content() by default. I also added the respective tests and updated relevant collections.

@edwinzhng edwinzhng requested review from nikhilro and lintool March 22, 2020 20:14
@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #1054 into master will increase coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1054      +/-   ##
============================================
+ Coverage     43.03%   43.06%   +0.03%     
- Complexity      634      638       +4     
============================================
  Files           133      135       +2     
  Lines          8077     8080       +3     
  Branches       1168     1168              
============================================
+ Hits           3476     3480       +4     
+ Misses         4271     4270       -1     
  Partials        330      330              
Impacted Files Coverage Δ Complexity Δ
...main/java/io/anserini/collection/AclAnthology.java 80.00% <ø> (ø) 3.00 <0.00> (ø)
.../java/io/anserini/collection/BibtexCollection.java 85.71% <ø> (ø) 3.00 <0.00> (ø)
...ain/java/io/anserini/collection/CarCollection.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...va/io/anserini/collection/ClueWeb09Collection.java 44.78% <ø> (ø) 2.00 <0.00> (ø)
...in/java/io/anserini/collection/CoreCollection.java 64.58% <ø> (ø) 3.00 <0.00> (ø)
...o/anserini/collection/CovidCollectionDocument.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/java/io/anserini/collection/HtmlCollection.java 62.22% <ø> (ø) 3.00 <0.00> (ø)
...in/java/io/anserini/collection/JsonCollection.java 72.54% <ø> (ø) 3.00 <0.00> (ø)
...io/anserini/collection/NewYorkTimesCollection.java 35.32% <ø> (ø) 3.00 <0.00> (ø)
...n/java/io/anserini/collection/TweetCollection.java 65.69% <ø> (ø) 2.00 <0.00> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7cbbb2...3081552. Read the comment docs.

Copy link
Member

@nikhilro nikhilro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@lintool
Copy link
Member

lintool commented Mar 23, 2020

Ref: #1048

@lintool lintool merged commit 56b18ee into master Mar 23, 2020
@lintool lintool deleted the source-refactor branch March 23, 2020 11:59
crystina-z pushed a commit to crystina-z/anserini that referenced this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants