Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in FEVER experiment regarding trec_eval params #1552

Merged
merged 1 commit into from
May 30, 2021

Conversation

kelvin-jiang
Copy link
Member

Initial discussion in #1551, ultimately decided that the best fix was to change '-m recall.100' to '-mrecall.100'.

@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #1552 (308f587) into master (62c4d4a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1552   +/-   ##
=========================================
  Coverage     57.04%   57.04%           
  Complexity      988      988           
=========================================
  Files           165      165           
  Lines          9219     9219           
  Branches       1278     1278           
=========================================
  Hits           5259     5259           
  Misses         3543     3543           
  Partials        417      417           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62c4d4a...308f587. Read the comment docs.

@lintool lintool merged commit 259d8ec into castorini:master May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants