Mrtydi regression #1702
Merged
Mrtydi regression #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1702 +/- ##
============================================
+ Coverage 57.31% 57.58% +0.26%
Complexity 1032 1032
============================================
Files 173 173
Lines 9721 9781 +60
Branches 1344 1344
============================================
+ Hits 5572 5632 +60
Misses 3675 3675
Partials 474 474
Continue to review full report at Codecov.
|
lintool
reviewed
Dec 15, 2021
| qrels = new RelevanceJudgments("src/main/resources/topics-and-qrels/qrels.mrtydi-v1.1-te.test.txt"); | ||
| assertNotNull(qrels); | ||
| assertEquals(646, qrels.getQids().size()); | ||
| assertEquals(677, getQrelsCount(qrels)); |
There was a problem hiding this comment.
This doesn't match the number in the Mr.TyDi paper, which says 664?
If so we should add a comment noting the difference...
Co-authored-by: Jimmy Lin <jimmylin@uwaterloo.ca>
lintool
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(unrelated to Mr.TyDi: add the path to /bin/build.sh in the readme)