Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated onboarding documents #2389

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Updated onboarding documents #2389

merged 3 commits into from
Feb 23, 2024

Conversation

ASChampOmega
Copy link
Contributor

Used Hardware:
(Used Waterloo Student Teaching Host ubuntu2204-002.student.cs.uwaterloo.ca)

CPU: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
RAM: 384GB

Environment:
Ubuntu 22.04.3 LTS
Python 3.10.12
Java 11.0.21
Apache Maven 3.6.3

Had many issues on my personal laptop, but non on student teaching host for anserini

Copy link
Member

@lintool lintool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit URL doesn't appear to be valid? 19c1984

tools shouldn't be part of the commit...

@ASChampOmega ASChampOmega requested a review from lintool February 23, 2024 12:57
@ASChampOmega
Copy link
Contributor Author

Hi Professor Lin!
I've made the changes

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.96%. Comparing base (f0b37dd) to head (b4b5bba).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2389   +/-   ##
=========================================
  Coverage     65.96%   65.96%           
  Complexity     1405     1405           
=========================================
  Files           207      207           
  Lines         11666    11666           
  Branches       1473     1473           
=========================================
  Hits           7695     7695           
  Misses         3461     3461           
  Partials        510      510           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lintool lintool merged commit 084deb9 into castorini:master Feb 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants