Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update experiments-msmarco-passage.md #2636

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Conversation

Divyajyoti02
Copy link
Contributor

There were issues in building the Anserini package on the Macbook Air M2 chip with 16 GB RAM and 256 GB memory. On building the package with maven (mvn clean package), the following error happens:

[ERROR] Failures:
[ERROR] ControllerTest.testSearch:42 expected:<10> but was:<0>

The error went away when I passed the DskipTests flag. The results were then reproducible successfully.

Also, it would be better for beginners if it is explained why an inverted index is necessary.

There were issues in building the Anserini package on the Macbook Air M2 chip with 16 GB RAM and 256 GB memory. On building the package with maven (mvn clean package), the following error happens:

[ERROR] Failures: 
[ERROR]   ControllerTest.testSearch:42 expected:<10> but was:<0>

The error went away when I passed the DskipTests flag. The results were then reproducible successfully.

Also, it would be better for beginners if it is explained why an inverted index is necessary.
@lintool
Copy link
Member

lintool commented Nov 24, 2024

Can you please collapse this and #2634 into a single PR?

Also, please provide more details regarding what happened to the failed test... we should look into more deeply.

Merging castorini#2634 into this PR.

Regarding the failed case, this happens while following step 2 in "Foundations of Retrieval" pathway ("BM25 Baselines for MS MARCO Passage Ranking in Anserini"). In the Indexing step, the tutorial asks us to build anserini using the "mvn clean package" command. Upon running the following error occurs.

[ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.054 s <<< FAILURE! - in io.anserini.server.ControllerTest
[ERROR] io.anserini.server.ControllerTest.testSearch  Time elapsed: 0.032 s  <<< FAILURE!
java.lang.AssertionError: expected:<10> but was:<0>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
	at io.anserini.server.ControllerTest.testSearch(ControllerTest.java:42)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:316)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:240)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:214)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:155)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495)

I suspect this test case does not impact the task because if I skip this test case by running "mvn clean package -DskipTests" everything works fine, and the code is reproducible.

Maven version: 3.9.9
Java version: 21.0.2
@lintool
Copy link
Member

lintool commented Nov 24, 2024

Please fix conflicts.

@Divyajyoti02
Copy link
Contributor Author

Fixed conflicts

@lintool lintool self-requested a review November 24, 2024 13:56
@lintool lintool merged commit beeac08 into castorini:master Nov 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants